Skip to content

Comments

Switch to GitHub issue forms#7773

Merged
opusforlife2 merged 8 commits intoTeamNewPipe:devfrom
litetex:use-gh-issue-forms
Feb 12, 2022
Merged

Switch to GitHub issue forms#7773
opusforlife2 merged 8 commits intoTeamNewPipe:devfrom
litetex:use-gh-issue-forms

Conversation

@litetex
Copy link
Member

@litetex litetex commented Feb 1, 2022

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

This is a first step/try to stop issue spamming by users which are unable to read the template/delete it.
Backstory: We got ~30 issue duplicates in one day despite having a pinned issue (→ #7734)

This switches our issue templates to GitHub issue form(s)-templates (still in beta) which should be more intuitive for users to fill out.

This is also a preparation for #6941

See also

Before/After Screenshots/Screen Record

→ Live demo: https://github.com/litetex/np-gh-issue-forms/issues/new/choose

  • Before:

  • After:

Due diligence

@litetex litetex added the meta Related to the project but not strictly to code label Feb 1, 2022
@opusforlife2
Copy link
Collaborator

opusforlife2 commented Feb 1, 2022

Is it okay even if they're still in beta? I know the Matrix/Element teams use them for all their repos.

@litetex litetex changed the title Switched to GitHub issue forms Switch to GitHub issue forms Feb 1, 2022
@opusforlife2
Copy link
Collaborator

opusforlife2 commented Feb 1, 2022

The dumdum CI shouldn't run when non-code files are modified.

@litetex
Copy link
Member Author

litetex commented Feb 1, 2022

Is it okay even if they're still in beta? I know the Matrix/Element teams use them for all their repos.

I think it works better than the current solution. However I did no long time monitoring so far.
In case of emergency we could also go back to the previous templates.

The dumdum CI shouldn't run when non-code files are modified.

A new issue with the CI label would be appreciated.
Also this could be helpful:
grafik

@opusforlife2 opusforlife2 mentioned this pull request Feb 1, 2022
Closed
@litetex litetex mentioned this pull request Feb 1, 2022
Closed
3 tasks
@nofishonfriday nofishonfriday mentioned this pull request Feb 4, 2022
Closed
@TheAssassin
Copy link
Member

TheAssassin commented Feb 10, 2022

Please feel free to take some inspiration from https://github.com/TheAssassin/AppImageLauncher/tree/master/.github/ISSUE_TEMPLATE. I think you mostly converted the existing template, but there is some potential for improvements. I'll leave a review shortly.

TheAssassin
TheAssassin reviewed Feb 10, 2022
View reviewed changes
Copy link
Member

@TheAssassin TheAssassin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed one of them now, but most of my feedback applies to all three.

@litetex
Copy link
Member Author

litetex commented Feb 11, 2022

@TheAssassin
Thank you for the feedback.
I reworked the templates accordingly (note that I modified some parts).

opusforlife2
opusforlife2 requested changes Feb 12, 2022
View reviewed changes
Copy link
Collaborator

@opusforlife2 opusforlife2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it. This is so much better than letting users manually fiddle with Markdown.

@litetex
Copy link
Member Author

litetex commented Feb 12, 2022

@opusforlife2
Thank you for the feedback.
I reworked the templates accordingly (note that I modified some parts).

opusforlife2
opusforlife2 previously approved these changes Feb 12, 2022
View reviewed changes
Copy link
Collaborator

@opusforlife2 opusforlife2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MERGE MERGE MERGE

triallax
triallax suggested changes Feb 12, 2022
View reviewed changes
@litetex
Copy link
Member Author

litetex commented Feb 12, 2022

@mhmdanas
Done

opusforlife2
opusforlife2 requested changes Feb 12, 2022
View reviewed changes
triallax
triallax approved these changes Feb 12, 2022
View reviewed changes
Copy link
Contributor

@triallax triallax left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yay no more issues with incomplete templates

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@opusforlife2 opusforlife2 merged commit e2a7b9a into TeamNewPipe:dev Feb 12, 2022
@opusforlife2
Copy link
Collaborator

opusforlife2 commented Feb 12, 2022

Thanks, litetex!

@litetex litetex deleted the use-gh-issue-forms branch February 13, 2022 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheAssassin TheAssassin TheAssassin left review comments

@opusforlife2 opusforlife2 opusforlife2 approved these changes

+2 more reviewers

@ChiefMikeK ChiefMikeK ChiefMikeK left review comments

@triallax triallax triallax approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

meta Related to the project but not strictly to code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@litetex @opusforlife2 @TheAssassin @ChiefMikeK @triallax